Fix unused parameter warnings in ShadowNode.h (#56519)#56519
Closed
christophpurrer wants to merge 1 commit into
Closed
Fix unused parameter warnings in ShadowNode.h (#56519)#56519christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101108467. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
Summary: Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters `sourceShadowNode` and `fragment` that were declared but not used in the function body. Also applied lint patch to remove redundant `virtual` keyword from the destructor declaration. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D101108467
christophpurrer
force-pushed
the
export-D101108467
branch
from
297715d to
2aad44e
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 21, 2026
Summary: Pull Request resolved: react#56519 Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters `sourceShadowNode` and `fragment` that were declared but not used in the function body. Also applied lint patch to remove redundant `virtual` keyword from the destructor declaration. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D101108467
christophpurrer
force-pushed
the
export-D101108467
branch
from
2aad44e to
100312f
Compare
Summary: Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters `sourceShadowNode` and `fragment` that were declared but not used in the function body. Also applied lint patch to remove redundant `virtual` keyword from the destructor declaration. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D101108467
christophpurrer
force-pushed
the
export-D101108467
branch
from
100312f to
60b75e4
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 19a23e7 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 19a23e7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters
sourceShadowNodeandfragmentthat were declared but not used in the function body.Also applied lint patch to remove redundant
virtualkeyword from the destructor declaration.Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D101108467